DJ Lucas wrote:
George Boudreau wrote:

Just playing the devil's advocate but have you run your script against a 2.6.12 kernel and compared your output to the 'official' 2.6.12 llh files.


There is still a little more to do. unifdef will leave quite a few empty files...well, empty cept for the 'hey I've already been included' define at the top. These should be removed and the relevent include lines removed from the rest of the headers. Also, there will be includes with 1 or 2 lines of code that fell before the ifdef __KERNEL__. These lines would be best moved to other dependent files as is done in the previous llh. None of the above matter from a functional standpoint, only cleanliness.


Also, diffs like the one below are showing....

================================================================================
diff -Naur linux-libc-headers-2.6.12.0/include/linux/acct.h linux-headers-2.6.12.0/include/linux/acct.h --- linux-libc-headers-2.6.12.0/include/linux/acct.h 2005-01-08 08:03:21.000000000 -0600 +++ linux-headers-2.6.12.0/include/linux/acct.h 2006-03-08 22:26:01.000000000 -0600
@@ -1,5 +1,114 @@
-#if defined(__GNUC__) && !defined(__STRICT_ANSI__)
-#warning "You should include <sys/acct.h>. This time I will do it for you."
+/*
+ *  BSD Process Accounting for Linux - Definitions
+ *
+ *  Author: Marco van Wieringen ([EMAIL PROTECTED])
...............
+#define ACCT_BYTEORDER 0x00    /* accounting file is little endian */
 #endif
-#include <sys/acct.h>

+#define ACCT_VERSION   2
+#define AHZ            (HZ)
+
+#endif /* _LINUX_ACCT_H */
================================================================================

And in 0.6 version of the script I see this...don't know why yet:

================================================================================
diff -Naur linux-libc-headers-2.6.12.0/include/linux/ata.h linux-headers-2.6.12.0/include/linux/ata.h --- linux-libc-headers-2.6.12.0/include/linux/ata.h 2005-03-25 13:36:50.000000000 -0600 +++ linux-headers-2.6.12.0/include/linux/ata.h 2006-03-08 22:25:56.000000000 -0600
@@ -196,31 +196,31 @@
 /* core structures */

 struct ata_prd {
-       __u32                   addr;
-       __u32                   flags_len;
+       u32                     addr;
+       u32                     flags_len;
........................
=================================================================================

There are others, <asm/types.h> are included in lots of places in llh where they are not included in raw kernel (or our script created ones).

Hope that helps some.

-- DJ Lucas
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to