> On June 15, 2015, 10:25 a.m., Laurent Montel wrote: > > plugins/texteffect/texteffectprefs.ui, line 85 > > <https://git.reviewboard.kde.org/r/124094/diff/1/?file=379855#file379855line85> > > > > Why added indent ?
meh, unintentional. My(editor's ?) bad :\ > On June 15, 2015, 10:25 a.m., Laurent Montel wrote: > > plugins/texteffect/texteffectpreferences.cpp, line 151 > > <https://git.reviewboard.kde.org/r/124094/diff/1/?file=379854#file379854line151> > > > > Wrong. > > CurrentItem ? > > it's always the same > > => you will store always the same item. I think QListWidget::Item(...) should work ? > On June 15, 2015, 10:25 a.m., Laurent Montel wrote: > > plugins/texteffect/texteffectpreferences.cpp, line 171 > > <https://git.reviewboard.kde.org/r/124094/diff/1/?file=379854#file379854line171> > > > > this list is single selection or multiselection ? I *think* it's a single selection. I'm presently behind a firewall and yahoo messenger seems to be blocked :\ - R.Harish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/#review81473 ----------------------------------------------------------- On June 19, 2015, 6:32 p.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124094/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 6:32 p.m.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Replace the K3ListBox classes with QListWidget. > > > Diffs > ----- > > plugins/texteffect/texteffectpreferences.cpp > 35fac60d419cbac5644a8e143be1fc7c640385a9 > plugins/texteffect/texteffectprefs.ui > 1b82f3de4b449373a3dedb39b664c0f645f1d02a > > Diff: https://git.reviewboard.kde.org/r/124094/diff/ > > > Testing > ------- > > Build succeeds. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
