----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/#review81473 -----------------------------------------------------------
plugins/texteffect/texteffectpreferences.cpp (line 101) <https://git.reviewboard.kde.org/r/124094/#comment55827> addItems ? plugins/texteffect/texteffectpreferences.cpp (line 151) <https://git.reviewboard.kde.org/r/124094/#comment55828> Wrong. CurrentItem ? it's always the same => you will store always the same item. plugins/texteffect/texteffectpreferences.cpp (line 171) <https://git.reviewboard.kde.org/r/124094/#comment55829> this list is single selection or multiselection ? plugins/texteffect/texteffectpreferences.cpp (line 235) <https://git.reviewboard.kde.org/r/124094/#comment55826> addItems ? plugins/texteffect/texteffectprefs.ui (line 85) <https://git.reviewboard.kde.org/r/124094/#comment55825> Why added indent ? plugins/texteffect/texteffectprefs.ui (line 244) <https://git.reviewboard.kde.org/r/124094/#comment55824> Please remove this part. It's not a customwidget now that it use a QListWidget - Laurent Montel On juin 14, 2015, 2:08 après-midi, R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124094/ > ----------------------------------------------------------- > > (Updated juin 14, 2015, 2:08 après-midi) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Replace the K3ListBox classes with QListWidget. > > > Diffs > ----- > > plugins/texteffect/texteffectpreferences.cpp > 35fac60d419cbac5644a8e143be1fc7c640385a9 > plugins/texteffect/texteffectprefs.ui > 1b82f3de4b449373a3dedb39b664c0f645f1d02a > > Diff: https://git.reviewboard.kde.org/r/124094/diff/ > > > Testing > ------- > > Build succeeds. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
