> On Июнь 20, 2015, 4:16 п.п., Laurent Montel wrote: > > plugins/texteffect/texteffectpreferences.cpp, line 151 > > <https://git.reviewboard.kde.org/r/124094/diff/4/?file=380500#file380500line151> > > > > why don't add directly ret.appent(...->item(f)->text()) ? > > Roman Nazarenko wrote: > Too much operations in a single line. Reading such a complex expression > is quite hard. It's also easier to handle code with GDB once all the > intermediate non-trivial evaluations results are stored in local variables. > > R.Harish Navnit wrote: > Ouch ! I just updated the diff according to what was suggested initially. > Do you want me to go the variable way over here ?
I think it's up to maintainer to decide. - Roman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124094/#review81595 ----------------------------------------------------------- On Июнь 21, 2015, 11:41 д.п., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124094/ > ----------------------------------------------------------- > > (Updated Июнь 21, 2015, 11:41 д.п.) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > Replace the K3ListBox classes with QListWidget. > > > Diffs > ----- > > plugins/texteffect/texteffectpreferences.cpp > 35fac60d419cbac5644a8e143be1fc7c640385a9 > plugins/texteffect/texteffectprefs.ui > 1b82f3de4b449373a3dedb39b664c0f645f1d02a > > Diff: https://git.reviewboard.kde.org/r/124094/diff/ > > > Testing > ------- > > Build succeeds. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
