> On May 10, 2012, 2:56 p.m., Lamarque Souza wrote: > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp, > > line 441 > > <http://svn.reviewboard.kde.org/r/6773/diff/2/?file=47673#file47673line441> > > > > As far as I know if the account is offline the move process is not > > going to work. I do not see why ask the user to do something that will not > > work. If you want to inform the user about that you should just show a > > warning message instead.
If you want to move metacontact to other group which contains some contact from offline account it is not possible due above check. But I think there should be option to force Kopete to move that metacontact. Imagine that you have some offline account which you are using once a month and you do not want to connect to them only for one stupid move... You are right that command "move to other group" will not be sent to account server, but at least it allow user to move also contacts from offline accounts - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6773/#review10793 ----------------------------------------------------------- On Feb. 25, 2012, 6:40 p.m., Pali Rohár wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6773/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2012, 6:40 p.m.) > > > Review request for Kopete. > > > Description > ------- > > Instead ignoring action move contact to group (and do not show any > warning/message), this patch ask user warning message if he really want to > move contact to group. This can be usefull if some accounts are offline and > user want to move metacontact (with contact belong to offline account) into > other group. > > > This addresses bug 202862. > https://bugs.kde.org/show_bug.cgi?id=202862 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp > 1282223 > > Diff: http://svn.reviewboard.kde.org/r/6773/diff/ > > > Testing > ------- > > Tested and working fine. > > > Thanks, > > Pali Rohár > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
