> On Aug. 23, 2011, 1:16 a.m., Raphael Kubo da Costa wrote: > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp, > > line 442 > > <http://svn.reviewboard.kde.org/r/6773/diff/1/?file=46823#file46823line442> > > > > msg could be const.
fixed > On Aug. 23, 2011, 1:16 a.m., Raphael Kubo da Costa wrote: > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp, > > line 443 > > <http://svn.reviewboard.kde.org/r/6773/diff/1/?file=46823#file46823line443> > > > > The i18n call should have some context (actually, using i18nc might be > > better here). > > Pali Rohár wrote: > What do you mean with "should have same context"? > > Raphael Kubo da Costa wrote: > I mean "add context to the translator". If a translator comes across > "Move" when translating Kopete, he is unable to know in what context it was > used, if this is a verb or a noun, what is supposed to be moved etc. > > So in this case you use i18nc() instead of i18n() to tell the translator > in what part of the code this is being used (if this is a menu item, a > dialog, a window title etc) and how. You can also use some semantic markup to > make it even easier for the translators to figure out the proper words to use > (see > http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics). I renamed "Move" to "Move contact". - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6773/#review10369 ----------------------------------------------------------- On Feb. 25, 2012, 6:40 p.m., Pali Rohár wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6773/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2012, 6:40 p.m.) > > > Review request for Kopete. > > > Description > ------- > > Instead ignoring action move contact to group (and do not show any > warning/message), this patch ask user warning message if he really want to > move contact to group. This can be usefull if some accounts are offline and > user want to move metacontact (with contact belong to offline account) into > other group. > > > This addresses bug 202862. > https://bugs.kde.org/show_bug.cgi?id=202862 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp > 1282223 > > Diff: http://svn.reviewboard.kde.org/r/6773/diff/ > > > Testing > ------- > > Tested and working fine. > > > Thanks, > > Pali Rohár > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
