-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6773/#review10369
-----------------------------------------------------------



/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp
<http://svn.reviewboard.kde.org/r/6773/#comment12108>

    msg could be const.



/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp
<http://svn.reviewboard.kde.org/r/6773/#comment12109>

    The i18n call should have some context (actually, using i18nc might be 
better here).


- Raphael


On Aug. 22, 2011, 3:34 p.m., Pali Rohár wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6773/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2011, 3:34 p.m.)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> Instead ignoring action move contact to group (and do not show any 
> warning/message), this patch ask user warning message if he really want to 
> move contact to group. This can be usefull if some accounts are offline and 
> user want to move metacontact (with contact belong to offline account) into 
> other group.
> 
> 
> This addresses bug 202862.
>     https://bugs.kde.org/show_bug.cgi?id=202862
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp 
> 1248151 
> 
> Diff: http://svn.reviewboard.kde.org/r/6773/diff
> 
> 
> Testing
> -------
> 
> Tested and working fine.
> 
> 
> Thanks,
> 
> Pali
> 
>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to