----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6848/#review10631 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.h <http://svn.reviewboard.kde.org/r/6848/#comment12831> Is there any need for the parameter role not be const? const int role. /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistplainmodel.cpp <http://svn.reviewboard.kde.org/r/6848/#comment12832> you can use: f |= Qt::ItemIsEditable; /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp <http://svn.reviewboard.kde.org/r/6848/#comment12833> same here. After fixing those small issues the patch is good to go in my oppinion. - Lamarque Souza On Jan. 5, 2012, 9:13 p.m., Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6848/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2012, 9:13 p.m.) > > > Review request for Kopete. > > > Description > ------- > > This adds a context option "rename" to contacts and allows to change the > custom displayname inline. In combination with a shortcut (typically F2) a > very comfortable way to quickly rename contacts. The displayname-source is > automatically set to "custom". > > > This addresses bug 206279. > https://bugs.kde.org/show_bug.cgi?id=206279 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.h 1271881 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp > 1271881 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistplainmodel.cpp > 1271881 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp > 1271881 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.h > 1271881 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp > 1271881 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp > 1271881 > /trunk/KDE/kdenetwork/kopete/kopete/kopeteui.rc 1271881 > > Diff: http://svn.reviewboard.kde.org/r/6848/diff/diff > > > Testing > ------- > > I used this for a few days, and it seems to work :-) > > > Thanks, > > Cyberbeat > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
