----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6848/#review10541 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp <http://svn.reviewboard.kde.org/r/6848/#comment12500> You should add a context here to make the word "Rename" easier to translate: http://techbase.kde.org/Development/Tutorials/Localization/i18n#Adding_Context_with_i18nc.28.29 Without the context the translator does not know if this work is noun or a verb. /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp <http://svn.reviewboard.kde.org/r/6848/#comment12499> You should use kDebug() instead. kDebug() message can be disabled at runtime using kdebugdialog, that makes ~/.xsession-errors less cluttered when someone disables Kopete's debug messages. /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp <http://svn.reviewboard.kde.org/r/6848/#comment12502> if you are not going to use this variable you should remove it the lines that set it above. /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp <http://svn.reviewboard.kde.org/r/6848/#comment12501> are these spaces? If so then please change them to tabs to comply with the coding style. The same for the lines below. - Lamarque Souza On Dec. 3, 2011, 1:23 p.m., Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6848/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2011, 1:23 p.m.) > > > Review request for Kopete. > > > Description > ------- > > This adds a context option "rename" to contacts and allows to change the > custom displayname inline. In combination with a shortcut (typically F2) a > very comfortable way to quickly rename contacts. The displayname-source is > automatically set to "custom". > > > This addresses bug 206279. > https://bugs.kde.org/show_bug.cgi?id=206279 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.h 1265679 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp > 1265679 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistplainmodel.cpp > 1265679 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp > 1265679 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.h > 1265679 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp > 1265679 > /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp > 1265679 > /trunk/KDE/kdenetwork/kopete/kopete/kopeteui.rc 1265679 > > Diff: http://svn.reviewboard.kde.org/r/6848/diff/diff > > > Testing > ------- > > I used this for a few days, and it seems to work :-) > > > Thanks, > > Cyberbeat > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
