> On March 1, 2011, 8:23 p.m., Frank Schaefer wrote: > > Hi Will, > > > > take a look at the discussion in Christis review request. The old code was > > incomplete (there were also bug reports), which was the reason for pushing > > this to stable, too. > > If you don't want the changes in the SUSE packages, you should at least add > > a dependency on the the jasper program package. > > For making libjasper optional, some more work is needed. > > > > I can't take a deeper look into this stuff at the moment, sorry. Hopefully > > I will find some free time next weekend. > > Will Stephenson wrote: > You can't change the dependencies in a minor release in a branch, even to > fix bugs. The dependency freeze was Nov 11 last year > (http://techbase.kde.org/Schedules/KDE4/4.6_Release_Schedule#Thursday.2C_November_11.2C_2010:_KDE_4.6_Dependency_Freeze). > Distributions and others have expectations and commitments to what packages > they ship in releases, and adding new packages, especially security-relevant > ones like image processing used from netcode, is taboo. > > This is blocking releasing KDE 4.6.1. > > I've fixed the unconditional linking of libjasper, what else is needed in > your opinion. > > > > cristip wrote: > If I may: > I don't know what are the policies re: releases/dependencies - though > some of what Will S. said makes sense. > I see 2 variants goign forward: > a) revert on that particular branch that doesn't accept changes the whole > damn patch. :-( better not :-) > b) I fear that with only this crt. patch, people that are *not* having > the libjasper dependency (like you mentioned) might end up in not being able > to use anymore yahoo webcam. > So, to fix this, I'd recommend you: > 1) put back the if ... 'jasper' exec. found in yahooaccount.cpp (when > those messages are displayed) > 2) and conditionally (#ifndef LIBJASPER....) put also back in several > places :-( the code that does the conversion through running the external > program (which my patch removed) > > > Frank Schaefer wrote: > Ok, then please just revert the changes in the stable branch (only). > > Some changes needed for trunk: > - enable/disable webcam invite/send webcam request buttons > - hide webcam if libjasper is not available > - negative reply if the contact sends a webcam invite and libjasper is > not available > - update the documentation (explain why yahoo video support may work or > work not depending on the distros build paramters choice...) > > Last point is why I'm not convinced that we should make libjasper > optional. Remember the libv4l disaster and all the bug reports we got...
Don't know who the last comment is addressed to, but: a) I can't revert code on branch - I do not have svn commit permissions b) re: the changes needed for trunk: I see in trunk that libjasper is mandatory so most of those things you asked to be implemented in trunk wouldn't make sense. What might make sense: 1) disable sendWebcam action if no VIDEO_SUPPORTED 2) also, if no VIDEO_SUPPORTED, on receiving a webcam invite, show a different message (like "X wants to view your webcam but there is no video support compiled. We will refuse this invitation") and on button click, send a refuse/declined answer. Btw, I'm thinking at some point we might want to use gstreamer for acessing webcam (+maybe nice transform effects) instead of direct v4l2. That way we might also reach Windows users. - cristip ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6562/#review9921 ----------------------------------------------------------- On Feb. 28, 2011, 8:16 p.m., Will Stephenson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6562/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2011, 8:16 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > Fix for http://reviewboard.kde.org/r/6312/, which makes libjasper a hard > dependency of the yahoo protocol and of Kopete overall. This makes it > optional and allows Yahoo to be used when built without libjasper, keeping > 4.6 branch's dependencies the same. > > Reuses the missing jasper executable message since 4.6 branch is in string > freeze. > > > This addresses bug 244135. > https://bugs.kde.org/show_bug.cgi?id=244135 > > > Diffs > ----- > > branches/KDE/4.6/kdenetwork/kopete/CMakeLists.txt 1223131 > branches/KDE/4.6/kdenetwork/kopete/config-kopete.h.cmake 1223131 > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/CMakeLists.txt 1223131 > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/libkyahoo/CMakeLists.txt > 1223131 > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/libkyahoo/webcamtask.cpp > 1223131 > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/yahoocontact.cpp 1223131 > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/yahoowebcam.cpp 1223131 > > Diff: http://svn.reviewboard.kde.org/r/6562/diff > > > Testing > ------- > > > Thanks, > > Will > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
