On Tuesday 01 Mar 2011 00:02:35 Cristi P wrote: > a) Heh... I remember I also wanted to keep the logic of deciding if you > want libjasper in a single place and play only from there (you can check > the patches).
I'm not sure exactly what you mean, but my patch is only going to restore the required dependencies of kdenetwork to the state 4.6.0 was released with. > b) you still seem to link unconditionally w/ jasper libs Thanks, fixed in updated diff at reviewboard: http://svn.reviewboard.kde.org/r/6562/ > c) you put back the message in there - but, if there's some user that > *does* have the 'jasper' program installed but not libjasper - it will > make him wonder what the hell is kopete saying... That's why we don't change dependencies and remove strings in released branches. Please can you respond at reviewboard instead of directly so we don't have 2 conversations going on. Will > On Mon, Feb 28, 2011 at 10:16 PM, Will Stephenson <wstephen...@kde.org>wrote: > > This is an automatically generated e-mail. To reply, visit: > > http://svn.reviewboard.kde.org/r/6562/ > > > > Review request for Kopete. > > > > By Will Stephenson. > > > > *Updated Feb. 28, 2011, 8:16 p.m.* > > Changes > > > > Mention string. > > > > Description (updated) > > > > Fix for http://reviewboard.kde.org/r/6312/ > > , which makes libjasper a hard dependency of the yahoo protocol and of > > Kopete overall. This makes it optional and allows Yahoo to be used when > > built without libjasper, keeping 4.6 branch's dependencies the same. > > > > Reuses the missing jasper executable message since 4.6 branch is in > > string freeze. > > > > *Bugs: * 244135 <https://bugs.kde.org/show_bug.cgi?id=244135> > > > > Diffs > > > > - branches/KDE/4.6/kdenetwork/kopete/CMakeLists.txt (1223131) > > - branches/KDE/4.6/kdenetwork/kopete/config-kopete.h.cmake (1223131) > > - branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/CMakeLists.txt > > (1223131) > > - > > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/libkyahoo/CMakeLis > > ts.txt (1223131) > > - > > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/libkyahoo/webcamta > > sk.cpp (1223131) > > - branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/yahoocontact.cpp > > (1223131) > > - branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/yahoowebcam.cpp > > (1223131) > > > > View Diff <http://svn.reviewboard.kde.org/r/6562/diff/> > > > > _______________________________________________ > > kopete-devel mailing list > > kopete-devel@kde.org > > https://mail.kde.org/mailman/listinfo/kopete-devel _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
