----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6562/#review9921 -----------------------------------------------------------
Hi Will, take a look at the discussion in Christis review request. The old code was incomplete (there were also bug reports), which was the reason for pushing this to stable, too. If you don't want the changes in the SUSE packages, you should at least add a dependency on the the jasper program package. For making libjasper optional, some more work is needed. I can't take a deeper look into this stuff at the moment, sorry. Hopefully I will find some free time next weekend. - Frank On Feb. 28, 2011, 8:16 p.m., Will Stephenson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6562/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2011, 8:16 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > Fix for http://reviewboard.kde.org/r/6312/, which makes libjasper a hard > dependency of the yahoo protocol and of Kopete overall. This makes it > optional and allows Yahoo to be used when built without libjasper, keeping > 4.6 branch's dependencies the same. > > Reuses the missing jasper executable message since 4.6 branch is in string > freeze. > > > This addresses bug 244135. > https://bugs.kde.org/show_bug.cgi?id=244135 > > > Diffs > ----- > > branches/KDE/4.6/kdenetwork/kopete/CMakeLists.txt 1223131 > branches/KDE/4.6/kdenetwork/kopete/config-kopete.h.cmake 1223131 > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/CMakeLists.txt 1223131 > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/libkyahoo/CMakeLists.txt > 1223131 > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/libkyahoo/webcamtask.cpp > 1223131 > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/yahoocontact.cpp 1223131 > branches/KDE/4.6/kdenetwork/kopete/protocols/yahoo/yahoowebcam.cpp 1223131 > > Diff: http://svn.reviewboard.kde.org/r/6562/diff > > > Testing > ------- > > > Thanks, > > Will > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
