----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6169/#review9368 -----------------------------------------------------------
Ship it! The two issues I've mentioned below are minor, so r+ from me. Are there any bug reports that can be closed by this commit? You'll probably need to backport to the 4.6 branch now too. /trunk/KDE/kdenetwork/kopete/protocols/skype/skypecalldialog.cpp <http://svn.reviewboard.kde.org/r/6169/#comment10376> I think the else is not necessary here. If the code enters the "if" path, it will return anyway, so the rest can just go in the main method scope. /trunk/KDE/kdenetwork/kopete/protocols/skype/skypecalldialog.cpp <http://svn.reviewboard.kde.org/r/6169/#comment10377> value can be declared here. - Raphael On 2010-12-21 01:22:46, Jeffery MacEachern wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6169/ > ----------------------------------------------------------- > > (Updated 2010-12-21 01:22:46) > > > Review request for Kopete and Pali Rohár. > > > Summary > ------- > > Originally, the balance display was hard-coded for Euros, and mistakenly > showed no balance otherwise. Using KCurrencyCode to parse the currency > abbreviation from Skype allows for it to display any currency Skype supports. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/skype/skypecalldialog.cpp 1207974 > > Diff: http://svn.reviewboard.kde.org/r/6169/diff > > > Testing > ------- > > Tried switching currencies on the Skype website to a few different ones, and > observing the result. I am not entirely certain that my use of > KCurrencyCode::subunitsPerUnit() is correct across all currencies, but it > worked in my tests. Confirmation of that would be appreciated. > > > Thanks, > > Jeffery > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
