-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6169/
-----------------------------------------------------------

Review request for Kopete and Pali Rohár.


Summary
-------

Originally, the balance display was hard-coded for Euros, and mistakenly showed 
no balance otherwise. Using KCurrencyCode to parse the currency abbreviation 
from Skype allows for it to display any currency Skype supports.


Diffs
-----

  /trunk/KDE/kdenetwork/kopete/protocols/skype/skypecalldialog.cpp 1207974 

Diff: http://svn.reviewboard.kde.org/r/6169/diff


Testing
-------

Tried switching currencies on the Skype website to a few different ones, and 
observing the result.  I am not entirely certain that my use of 
KCurrencyCode::subunitsPerUnit() is correct across all currencies, but it 
worked in my tests.  Confirmation of that would be appreciated.


Thanks,

Jeffery

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to