----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6169/ -----------------------------------------------------------
(Updated 2010-12-21 01:22:46.810691) Review request for Kopete and Pali Rohár. Changes ------- I double-checked the Skype API docs, and realized that the subunitsPerUnit() call is actually not needed in this case, as Skype has the precision fixed at two decimal places no matter what. Summary ------- Originally, the balance display was hard-coded for Euros, and mistakenly showed no balance otherwise. Using KCurrencyCode to parse the currency abbreviation from Skype allows for it to display any currency Skype supports. Diffs (updated) ----- /trunk/KDE/kdenetwork/kopete/protocols/skype/skypecalldialog.cpp 1207974 Diff: http://svn.reviewboard.kde.org/r/6169/diff Testing ------- Tried switching currencies on the Skype website to a few different ones, and observing the result. I am not entirely certain that my use of KCurrencyCode::subunitsPerUnit() is correct across all currencies, but it worked in my tests. Confirmation of that would be appreciated. Thanks, Jeffery
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
