----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1004/#review1595 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/libkopete/kopetecommandhandler.cpp <http://reviewboard.kde.org/r/1004/#comment1030> I think it is a good thing not relying one p->processMap.remove not derefing proc. /trunk/KDE/kdenetwork/kopete/protocols/groupwise/libgroupwise/coreprotocol.cpp <http://reviewboard.kde.org/r/1004/#comment1031> m_din is compared to 0L in another method. /trunk/KDE/kdenetwork/kopete/protocols/irc/irccontact_channel.cpp <http://reviewboard.kde.org/r/1004/#comment1032> I know the whole irc source code is commented, this is just in case someone uncomments it. actionHomepage is compared to 0L some lines bellow. /trunk/KDE/kdenetwork/kopete/protocols/jabber/jingle/jinglertpsession.cpp <http://reviewboard.kde.org/r/1004/#comment1033> Maybe this is not needed, but since socket can be used outside this method I think it is a good thing initialise it properly. /trunk/KDE/kdenetwork/kopete/protocols/jabber/jingle/jinglertpsession.cpp <http://reviewboard.kde.org/r/1004/#comment1034> Maybe this is not needed, but since socket can be used outside this method I think it is a good thing initialise it properly. /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/irisnet/corelib/netinterface.cpp <http://reviewboard.kde.org/r/1004/#comment1035> Maybe this is not needed, but since tracker can be used outside this method I think it is a good thing initialise it properly. /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/jingle/jinglecontent.cpp <http://reviewboard.kde.org/r/1004/#comment1036> Maybe this is not needed, but since d->outTimer can be used outside this method I think it is a good thing initialise it properly. /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/jingle/jinglesessionmanager.cpp <http://reviewboard.kde.org/r/1004/#comment1037> Maybe this is not needed, but since d->http can be used outside this method I think it is a good thing initialise it properly. /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/xmpp-core/parser.cpp <http://reviewboard.kde.org/r/1004/#comment1038> Maybe this is not needed, but since those variables can be used outside this method I think it is a good thing initialise them properly. /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgahclist.cpp <http://reviewboard.kde.org/r/1004/#comment1039> This will only be a problem if this slot is called twice in a row. I do not know how likely that is so just to make sure it will not crash Kopete. /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabberregister.cpp <http://reviewboard.kde.org/r/1004/#comment1040> Maybe this is not needed, but since lblWait can be used outside this method I think it is a good thing initialise it properly. /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgregister.cpp <http://reviewboard.kde.org/r/1004/#comment1041> Maybe this is not needed, but since lblWait can be used outside this method I think it is a good thing initialise it properly. /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgsearch.cpp <http://reviewboard.kde.org/r/1004/#comment1042> Maybe this is not needed, but since ui.lblWait can be used outside this method I think it is a good thing initialise it properly. /trunk/KDE/kdenetwork/kopete/protocols/sms/smseditaccountwidget.cpp <http://reviewboard.kde.org/r/1004/#comment1043> Maybe this is not needed, but since configWidget can be used outside this method I think it is a good thing initialise it properly. - Lamarque On 2009-07-14 20:00:08, Lamarque Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1004/ > ----------------------------------------------------------- > > (Updated 2009-07-14 20:00:08) > > > Review request for Kopete. > > > Summary > ------- > > Initialise deleted pointers to 0L. Throughout all Kopete source code pointers > are deleted and not initialized, grep -r 'delete ' $(find \( -name "*.cpp" > -o -name "*.h" \) ) | wc returns 1105 lines, I can do a rough estimation of > at least half of those lines do not reinitialize pointers. Althouth > reinitialing pointers are not always necessary in some cases it does is > necessary and by what I have seen there are such places in Kopete's source > code. Kopete::CommandHandler::slotExecFinished even passed one deleted > pointer to a function, which seems really wrong to me, it should delete the > pointer after calling the function, not before. To illustrate the problem > assume a is a class member pointer: > > delete a; // in one class method > > // In another class method: > if (a) // the result will the true even though a is deleted > do a->"something" // this can crash the application > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecommandhandler.cpp 993925 > > /trunk/KDE/kdenetwork/kopete/protocols/groupwise/libgroupwise/coreprotocol.cpp > 993925 > /trunk/KDE/kdenetwork/kopete/protocols/irc/irccontact_channel.cpp 993925 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jingle/jinglertpsession.cpp > 993925 > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/irisnet/corelib/netinterface.cpp > 993925 > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/jingle/jinglecontent.cpp > 993925 > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/jingle/jinglesessionmanager.cpp > 993925 > > /trunk/KDE/kdenetwork/kopete/protocols/jabber/libiris/iris/xmpp/xmpp-core/parser.cpp > 993925 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgahclist.cpp 993925 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgjabberregister.cpp > 993925 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgregister.cpp 993925 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/ui/dlgsearch.cpp 993925 > /trunk/KDE/kdenetwork/kopete/protocols/sms/smseditaccountwidget.cpp 993925 > > Diff: http://reviewboard.kde.org/r/1004/diff > > > Testing > ------- > > > Thanks, > > Lamarque > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
