On Mon, Feb 2, 2009 at 12:27 PM, Gustavo Pichorim Boiko <gustavo.bo...@kdemail.net> wrote: > Hi > > Em 02/02/2009, às 14:00, Benson Tsai escreveu: > >> Well for starters, in my opinion, it shouldn't be scaling the image >> unless it needs to, but it is scaling anything that doesn't fit into a >> 96 by 96 box. That being said, it only down scales and doesn't upscale >> (i don't particularly think it should be upscaling either...). >> >> Anyway, I attached two images, one showing the contact list and one >> showing the chat window. On the left of both is the original, on the >> right with the patch (and some other little things, but focus on the >> contact photos). Take the 3rd icon counting from the top for example >> (which is a cat). On the left side, the cat icon is scaled down >> needlessly on the right it uses its original size. > > I guess now I got your point. In fact the icons are not downscaled by > the avatar manager itself, but when the displaying of icons is smaller > than 96x96, the icons then get downscaled. Good catch. > > I guess the proper solution for this would be to: > 1) scale down icons bigger than 96x96 (there is no need to keep the > original size in this case) > 2) save smaller icons in the original size (without centering in a > 96x96 box) and use a QIcon (or even a customized QIconEngine) that > returns the pixmap rescaled and in case a bigger size is requested > center the icon and fill the empty spaces. > > >> In the photo with the chat windows, the left side has a much scaled >> down kirby (with a hat) where as the right side has the full image. >> >> Perhaps the avatar manager should be upscaling photos that are too >> big. However, that would be a bad idea if animated images were to be >> supported because afaik, QT does not support saving animated images. > > Well, I wonder what's the real use of animated avatar images :) > > Cheers > > Boiko > _______________________________________________ > kopete-devel mailing list > kopete-devel@kde.org > https://mail.kde.org/mailman/listinfo/kopete-devel >
Just to clarify, when you say "save smaller icons in the original size", do you mean use QT to save the image? In my opinion, we should just save the original without touching it. This way you can preserve animation (if any, since QT can read animated images, but not write). On the other hand, the scaling done by the avatar manager is still expected by protocols that need to abide by that restriction. IMO, the protocols probably should be scaling by themselves to the necessary size instead of expecting the avatar manager to hand the exact right size (which is probably why 96x96 is used since it is the size that is supported across the board). --Benson Tsai _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
