vonreth added inline comments. INLINE COMMENTS
> notifybysnore.cpp:23 > + > +#include <Windows.h> > + Is anything from Windows needed? The header is huge. > vonreth wrote in notifybysnore.cpp:180 > Use proc->deleteLater() which will call the destructor > https://doc.qt.io/qt-5/qprocess.html#dtor.QProcess Only delete once 🙈 > pino wrote in notifybysnore.cpp:49 > `iconDir` is leaked FromStdString is wrong, use fromLatin1. What about qHash, we don't ned cryptography algorithm here REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
