davidedmundson added inline comments. INLINE COMMENTS
> broulik wrote in packagejob.cpp:90 > Can this be invalid or does `install` already check for validity? bool PackageJobThread::installPackage(const QString &src, const QString &dest, OperationType operation) { ... if (!meta.isValid()) { qCDebug(KPACKAGE_LOG) << "No metadata file in package" << src << path; d->errorMessage = i18n("No metadata file in package: %1", src); d->errorCode = Package::JobError::MetadataFileMissingError; return false; } REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D15177 To: davidedmundson, #plasma Cc: broulik, Zren, kde-frameworks-devel, michaelh, ngraham, bruns