broulik added inline comments.

INLINE COMMENTS

> packagejob.cpp:90
> +        if (ok) {
> +            const QString pluginId = d->package->metadata().pluginId();
> +            const QStringList serviceTypes = 
> d->package->metadata().serviceTypes();

Can this be invalid or does `install` already check for validity?

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D15177

To: davidedmundson, #plasma
Cc: broulik, Zren, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to