D15177: Emit signals when a package is installed/uninstalled

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> packagejob.cpp:93
> +            for (auto packageType: serviceTypes) {
> +                auto msg = 
> QDBusMessage::createSignal(QStringLiteral("/KPackage/") + packageType, 
> QStringLiteral("org.kde.plasma.kpackage"), 
> QStringLiteral("packageInstalled"));
> +                msg.setArguments({pluginId});

Can `packageType` contain characters not allowed in DBus?

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D15177

To: davidedmundson, #plasma
Cc: broulik, Zren, kde-frameworks-devel, michaelh, ngraham, bruns