ibragimovrinat added inline comments. INLINE COMMENTS
> cfeck wrote in ktar.cpp:777 > Does the spec say `> 99` or `> 100`? The comment and the code should match. The comment is right in some sense, 100 bytes means 99 bytes of name and 1 byte of '\0'. I don't know for sure if there is a (single) spec actually. At least GNU tar (http://www.gnu.org/software/tar/manual/html_node/Standard.html) mentions that although name[100] is a 100-byte field, "The name, linkname, magic, uname, and gname are null-terminated character strings." So, there could be string of at most 99 bytes, plus a zero-terminator. However, there is a special case in this source file where 100-byte but non-zero-terminated names are handled (search for "bug:101472" string in the source). Maybe, there are such tar files in the wild. How should I change the comment? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns
