ibragimovrinat created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ibragimovrinat requested review of this revision.
REVISION SUMMARY BUG: 266141 As UTF-8 may use multiple bytes per character, it's required to measure encoded file name length in bytes, not just in characters. It's possible to accidentally truncate file name if its name in characters is shorter that 100, but in bytes — longer than 100. Also, checksum calculation must be performed on unsigned bytes. Otherwise bytes in range 0x80-0xff when promoted to int become negative. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 AFFECTED FILES src/ktar.cpp To: ibragimovrinat Cc: ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns
