kossebau added a subscriber: broulik. kossebau added a comment.
Thanks for proposing a patch. for the bug @ibragimovrinat Myself I only contributed once in former times to karchive, all memories lost, not sure if I have time to dive into that codebase again, despite @broulik here poking me :) One thing though for sure which would be wanted here is hardening the code by having some unit tests covering ascii-only and non-ascii file names. So whoever might review this patch surely would like to see some samples tested somewhere below autotests/ :) REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns