dfaure added inline comments. INLINE COMMENTS
> klineedit.cpp:184 > > - q->connect(q, SIGNAL(textChanged(QString)), q, > SLOT(_k_textChanged(QString))); > + q->connect(q, SIGNAL(textChanged(QString)), q, > SLOT(_k_textEmitted(QString))); > } Why did you rename the slot? I don't understand "textEmitted", and the signal is of course still called textChanged. Isn't the slot renaming just noise? REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9808 To: dweatherill, #frameworks, dhaumann, cullmann Cc: dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
