dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
Thanks for the fix. Looking at the reasoning in https://phabricator.kde.org/R284:737a983febf4b44b5447c26d86eaedc624a8c35f the added emit is definitely wrong, as the unittest proves. Please push. INLINE COMMENTS > klineedit_unittest.cpp:71 > QCOMPARE(textChangedSpy[0][0].toString(), w.text()); > - QCOMPARE(textEditedSpy.count(), 1); > + QCOMPARE(textEditedSpy.count(), 0); > QVERIFY(!w.isModified()); LOL the comment above says "setText emits textChanged and userTextChanged, but not textEdited", and the code didn't match that. Someone quickly adapted the tests after someone else added the emit, none of them really thought about this, sigh. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9808 To: dweatherill, #frameworks, dhaumann, cullmann, dfaure Cc: mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
