dweatherill created this revision. dweatherill added a reviewer: Frameworks. dweatherill added a project: KDevelop. Restricted Application added a project: Frameworks. dweatherill requested review of this revision.
REVISION SUMMARY This goes with bug report https://bugs.kde.org/show_bug.cgi?id=388798 The unit test of kLineEdit was previously checking incorrectly that textEmitted _HAD_ been emitted when the text is changed with setText(). This is undesired behaviour. This patch fixes the unit test, and changes the problematic behaviour. In addition, the private signal is renamed from _k_textChanged to _k_textEmitted to better reflect the desired semantics inline with QLineEdit. In addition this is the underlying cause of bug https://bugs.kde.org/show_bug.cgi?id=373004 in kdevelop (and probably several others). REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9808 AFFECTED FILES autotests/klineedit_unittest.cpp src/klineedit.cpp src/klineedit.h src/klineedit_p.h To: dweatherill, #frameworks Cc: iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
