cfeck added inline comments. INLINE COMMENTS
> cfeck wrote in kpasswordlineedit.cpp:30 > Does this class need to be a QObject? If not, remove the QObject stuff. Ping? > kpasswordlineedit.h:53 > + Q_PROPERTY(bool clearButtonEnabled READ isClearButtonEnabled WRITE > setClearButtonEnabled) > + Q_PROPERTY(QLineEdit::EchoMode echoMode READ echoMode WRITE setEchoMode) > +public: NOTIFY echoModeChanged > kpasswordlineedit.h:83 > + /** > + * Show/hide clear button > + */ Document default value. > kpasswordlineedit.h:93 > + /** > + * Change echo mode > + */ Please document the default value. If it is indeed QLineEdit::Password (which I would expect), remove the properties from the .ui files. REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kossebau, elvisangelaccio, #frameworks
