kossebau added inline comments. INLINE COMMENTS
> knewpasswordwidget.ui:88 > + <class>KPasswordLineEdit</class> > + <extends>QLineEdit</extends> > + <header>kpasswordlineedit.h</header> rather extends QWidget now? unsure what exactly the consequences are > kpassworddialog.ui:163 > + <class>KPasswordLineEdit</class> > + <extends>QLineEdit</extends> > + <header>kpasswordlineedit.h</header> Again QWidget? > kpasswordlineedit.h:6 > + modify it under the terms of the GNU Library General Public > + License version 2 as published by the Free Software Foundation. > + Should this not be rather lgpl2_+_? see https://community.kde.org/Policies/Licensing_Policy REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kossebau, elvisangelaccio, #frameworks
