cfeck added inline comments. INLINE COMMENTS
> knewpasswordwidget.cpp:75 > > - connect(ui.linePassword, SIGNAL(textChanged(QString)), q, > SLOT(_k_showToggleEchoModeAction(QString))); > - connect(ui.linePassword, SIGNAL(textChanged(QString)), q, > SLOT(_k_textChanged())); > + connect(ui.linePassword, SIGNAL(passwordChanged(QString)), q, > SLOT(_k_textChanged())); > connect(ui.lineVerifyPassword, SIGNAL(textChanged(QString)), q, > SLOT(_k_textChanged())); While you are at renaming slots: -> _k_passwordChanged > kpasswordlineedit.h:121 > + */ > + void setRevealPasswordAvailable(bool reveal); > + Please move the documentation for public functions above the documentation for internal functions (for those that read .h files, instead of apidox). REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kossebau, elvisangelaccio, #frameworks
