----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review101822 -----------------------------------------------------------
Note: This got reverted in master for now, since there were too many warnings caused by this change. We'll reapply it after the KF5 release. Most of the warnings have been fixed by Laurent a few days ago (and I have a few more patches I'll push after the release). - Kevin Funk On Dec. 29, 2016, 11:48 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129724/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2016, 11:48 p.m.) > > > Review request for Build System and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Gives a nice warning about something that should be marked as override but > isn't > > > Diffs > ----- > > kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 > > Diff: https://git.reviewboard.kde.org/r/129724/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
