----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review101662 -----------------------------------------------------------
Ship it! LGTM, and the Clang equivalent (-Winconsistent-missing-override) appears to already be picked up in its -Wall setting. - Michael Pyne On Dec. 29, 2016, 11:07 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129724/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2016, 11:07 p.m.) > > > Review request for Build System and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Gives a nice warning about something that should be marked as override but > isn't > > > Diffs > ----- > > kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 > > Diff: https://git.reviewboard.kde.org/r/129724/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
