> On Dez. 30, 2016, 7:39 vorm., Martin Gräßlin wrote: > > Is that enabled by default now? I hope not! This is a completely useless > > warning for all frameworks (as we are not allowed to use override) and even > > more for a legacy code bases. I don't want to have to adjust the cmake in > > all projects I maintain to silence this warning again. And even less I want > > to spent days adding overrides to legacy code base. > > Laurent Montel wrote: > We can use Q_DECL_OVERRIDE which is replaced by override when your gcc > support it. So There is not a problem to use this flags no ?
I commented on that aspect in the past. We cannot have both: enforce C++11 and at the same time keep compatibility to no C++11. We need to find a real line and not bullshit around with macros. Either we say C++11 then enable all of it, or say no. But then no earnings please. I'm seriously annoyed by the stupid dance we are doing. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review101664 ----------------------------------------------------------- On Dez. 30, 2016, 12:48 vorm., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129724/ > ----------------------------------------------------------- > > (Updated Dez. 30, 2016, 12:48 vorm.) > > > Review request for Build System and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Gives a nice warning about something that should be marked as override but > isn't > > > Diffs > ----- > > kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3 > > Diff: https://git.reviewboard.kde.org/r/129724/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
