----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128730/#review98541 -----------------------------------------------------------
unfortunately just making those classes not explode even tough inoperative may be the only solution but this seem to unconditionally render this inoperative? (never creates the dialog, even when there is a qapp? src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp (line 38) <https://git.reviewboard.kde.org/r/128730/#comment66384> should create the m_dialog instance in this branch? - Marco Martin On Aug. 21, 2016, 5:36 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128730/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2016, 5:36 p.m.) > > > Review request for KDE Frameworks and Marco Martin. > > > Repository: kdeclarative > > > Description > ------- > > This happens when QtCreator launches qmlplugindump. > Testcase: qmlplugindump -nonrelocatable org.kde.plasma.calendar 2.0 > /usr/lib64/qml > > There are more similar issues, e.g. in > plasma-framework/src/declarativeimports/plasmacomponents/qmenu.cpp > > > Diffs > ----- > > src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp > 4fc7dcc99c7474b4658150c3622c5685d092e6ad > > Diff: https://git.reviewboard.kde.org/r/128730/diff/ > > > Testing > ------- > > as mentionned above > > > Thanks, > > David Faure > >
