> On Aug. 21, 2016, 5:56 p.m., Anthony Fieroni wrote: > > src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp, line 31 > > <https://git.reviewboard.kde.org/r/128730/diff/1/?file=475025#file475025line31> > > > > You mean IconDialog is instantiate *before* QApplication? If it's true, > > i think this is wrong place to patch it.
No, this is not about before. This is about the program (qmlplugindump) creating only a QGuiApplication. No widgets allowed. We cannot create any widgets, so we have to render this class inoperative. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128730/#review98530 ----------------------------------------------------------- On Aug. 21, 2016, 5:36 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128730/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2016, 5:36 p.m.) > > > Review request for KDE Frameworks and Marco Martin. > > > Repository: kdeclarative > > > Description > ------- > > This happens when QtCreator launches qmlplugindump. > Testcase: qmlplugindump -nonrelocatable org.kde.plasma.calendar 2.0 > /usr/lib64/qml > > There are more similar issues, e.g. in > plasma-framework/src/declarativeimports/plasmacomponents/qmenu.cpp > > > Diffs > ----- > > src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp > 4fc7dcc99c7474b4658150c3622c5685d092e6ad > > Diff: https://git.reviewboard.kde.org/r/128730/diff/ > > > Testing > ------- > > as mentionned above > > > Thanks, > > David Faure > >
