----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128730/#review98539 -----------------------------------------------------------
Is there a way to say that the qml import may only be used if it's a QApplication? I'm not sure whether it makes sense to patch out all places where a QWidget dependency is used. In the end it will be broken in the runtime anyway. - Martin Gräßlin On Aug. 21, 2016, 7:36 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128730/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2016, 7:36 p.m.) > > > Review request for KDE Frameworks and Marco Martin. > > > Repository: kdeclarative > > > Description > ------- > > This happens when QtCreator launches qmlplugindump. > Testcase: qmlplugindump -nonrelocatable org.kde.plasma.calendar 2.0 > /usr/lib64/qml > > There are more similar issues, e.g. in > plasma-framework/src/declarativeimports/plasmacomponents/qmenu.cpp > > > Diffs > ----- > > src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp > 4fc7dcc99c7474b4658150c3622c5685d092e6ad > > Diff: https://git.reviewboard.kde.org/r/128730/diff/ > > > Testing > ------- > > as mentionned above > > > Thanks, > > David Faure > >
