----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128159/#review96422 -----------------------------------------------------------
src/mainwindow.h (line 52) <https://git.reviewboard.kde.org/r/128159/#comment65131> it's => is src/mainwindow.h (line 53) <https://git.reviewboard.kde.org/r/128159/#comment65132> Not sure you want to explicitly link to something that people should basically ignore ;-) @see setupGUI, @see createGUI would probably be more useful. - David Faure On June 13, 2016, 2:49 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128159/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 2:49 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kparts > > > Description > ------- > > KXMLGui-based apps should always use `setupGUI()`, which has several > advantages over `setXMLFile()` and calls it implicitly. > > This patch also adds a code snippet about this. > > > Diffs > ----- > > src/mainwindow.h b672a35cba92475200ff15620a21150da19582dd > > Diff: https://git.reviewboard.kde.org/r/128159/diff/ > > > Testing > ------- > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
