----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128159/#review96414 -----------------------------------------------------------
src/mainwindow.h (line 43) <https://git.reviewboard.kde.org/r/128159/#comment65128> Hmm, Default includes Create, so this is going to call createGUI twice, the first time wrongly (no part yet). The other reasons why setupGUI didn't work for KParts::MainWindow seem to be gone though, I see that the standard actions for configuring Keys, StatusBar, ToolBar should work. So maybe just adjust the example to pass e.g. Keys|ToolBar|Save, and mention that Default shouldn't be used? - David Faure On June 12, 2016, 4:57 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128159/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 4:57 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kparts > > > Description > ------- > > KXMLGui-based apps should always use `setupGUI()`, which has several > advantages over `setXMLFile()` and calls it implicitly. > > This patch also adds a code snippet about this. > > > Diffs > ----- > > src/mainwindow.h b672a35cba92475200ff15620a21150da19582dd > > Diff: https://git.reviewboard.kde.org/r/128159/diff/ > > > Testing > ------- > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
