-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128159/
-----------------------------------------------------------

(Updated June 13, 2016, 2:49 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

* Removed the Create flag from setupGUI()
* Moved the last paragraph at the beginning, where it makes more sense.


Repository: kparts


Description
-------

KXMLGui-based apps should always use `setupGUI()`, which has several advantages 
over `setXMLFile()` and calls it implicitly. 

This patch also adds a code snippet about this.


Diffs (updated)
-----

  src/mainwindow.h b672a35cba92475200ff15620a21150da19582dd 

Diff: https://git.reviewboard.kde.org/r/128159/diff/


Testing
-------


Thanks,

Elvis Angelaccio

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to