> On Jan. 26, 2016, 7:31 a.m., David Faure wrote:
> > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195
> > <https://git.reviewboard.kde.org/r/126876/diff/1/?file=439596#file439596line195>
> >
> > OK then you can remove the "is that a BUG" question here.
> >
> > I'm still curious as to who is passing a url with a filename here; Qt
> > or the app.
> >
> > In any case the comment is confusing, "Qt returns", this is rather
> > about Qt calling this method, not "returning".
In Kate we have the code (kateviewmanager.cpp line 238):
const QList<QUrl> urls = QFileDialog::getOpenFileUrls(m_mainWindow,
i18n("Open File"), cv->document()->url());
here "cv->document()->url()" is a QUrl and includes the file name of the
current document.
When this call is done we eventually end up in void
KDEPlatformFileDialogHelper::initializeDialog() and in there is the line:
setDirectory(options()->initialDirectory());
For local files "options()->initialDirectory()" returns the original URL
stripped of it's fileName.
For remote files "options()->initialDirectory()" returns the original URL
unchanged.
- Kåre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126876/#review91605
-----------------------------------------------------------
On Jan. 24, 2016, 9:19 p.m., Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126876/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 9:19 p.m.)
>
>
> Review request for KDE Frameworks, Alex Richardson and David Faure.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> This fix is a bit like Alex Richardson workaround in KIO
> (https://git.reviewboard.kde.org/r/126831/), but in frameworkintegration in
> stead (I did not see his/Your KIO fix before now...)
>
> I check the remote url in setDirectory() because setDirectoy() is called from
> two places.
>
>
> Diffs
> -----
>
> src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb
>
> Diff: https://git.reviewboard.kde.org/r/126876/diff/
>
>
> Testing
> -------
>
> Kate now happily opens local and remote folders :)
>
>
> Thanks,
>
> Kåre Särs
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
