-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/#review74271
-----------------------------------------------------------
I'm confused, why do the unittest changes include a change in the way
translation works? ("translations happen at runtime now" -- this isn't what
this patch is about, is it?)
autotests/kplugininfotest.cpp
<https://git.reviewboard.kde.org/r/121737/#comment51559>
I would suggest removing the TODO and the questions.
- David Faure
On Jan. 16, 2015, 11:52 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121737/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 11:52 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> This should fix property() returning empty QVariants even if it
> existed in the .desktop file
>
>
> Diffs
> -----
>
> autotests/fakeplugin.desktop 9c6df7ffdb95f9e1b6e6f921040db00e8e5565ff
> autotests/fakeplugin.json 067a302505956c34e940ce0f6facd8a1745384ec
> autotests/kplugininfotest.cpp b520a9ca83e88fe5e4a2d53d4e05d7eb9764beea
> src/services/kplugininfo.cpp 35e09fa49603a3c9fd5b534cacf46c18c848eaf4
>
> Diff: https://git.reviewboard.kde.org/r/121737/diff/
>
>
> Testing
> -------
>
> KDED now correctly reads X-Kded-* in
> https://git.reviewboard.kde.org/r/121315/ instead of reading the default
> value.
>
>
> Thanks,
>
> Alex Richardson
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
