----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/#review74270 -----------------------------------------------------------
Yes it's correct that KService merges servicetypes and mimetypes. But let's say it's historical, these two things are more separated than they were in KDE3 times. The idea is/was that "services that can open a JPEG file" *is* a type of service, i.e. a servicetype. But I wouldn't mind more separation in newer code (heck, we don't have KMimeType inheriting KServiceType anymore, QMimeType is separate). - David Faure On Jan. 16, 2015, 11:52 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121737/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 11:52 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kservice > > > Description > ------- > > This should fix property() returning empty QVariants even if it > existed in the .desktop file > > > Diffs > ----- > > autotests/fakeplugin.desktop 9c6df7ffdb95f9e1b6e6f921040db00e8e5565ff > autotests/fakeplugin.json 067a302505956c34e940ce0f6facd8a1745384ec > autotests/kplugininfotest.cpp b520a9ca83e88fe5e4a2d53d4e05d7eb9764beea > src/services/kplugininfo.cpp 35e09fa49603a3c9fd5b534cacf46c18c848eaf4 > > Diff: https://git.reviewboard.kde.org/r/121737/diff/ > > > Testing > ------- > > KDED now correctly reads X-Kded-* in > https://git.reviewboard.kde.org/r/121315/ instead of reading the default > value. > > > Thanks, > > Alex Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
