----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review69260 -----------------------------------------------------------
Ship it! Just one last thing, then push. src/widgets/krun.cpp <https://git.reviewboard.kde.org/r/120666/#comment48419> Why not pass dialog->isDontAskAgainChecked() to the "slot" (which is not really a slot, so the slot prefix should be removed...) Then the member var m_dialogDoNotAskAgainSet won't be needed anymore. - David Faure On Oct. 28, 2014, 11:43 a.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120666/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 11:43 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > This patch makes KIO show a dialog box asking the user what to do (either > open it using a text editor or execute it) when he clicks on a script or a > desktop file. > > See also: https://git.reviewboard.kde.org/r/120171/ > > > Diffs > ----- > > src/widgets/krun.cpp 6ac42da > src/widgets/krun_p.h 69e2e98 > src/widgets/CMakeLists.txt 4060cdf > src/widgets/executablefileopendialog.cpp PRE-CREATION > src/widgets/executablefileopendialog_p.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120666/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
