----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review69246 -----------------------------------------------------------
src/widgets/executablefileopendialog.cpp <https://git.reviewboard.kde.org/r/120666/#comment48410> where is this slot used? src/widgets/krun.cpp <https://git.reviewboard.kde.org/r/120666/#comment48411> This should use the 4 args connect, in case the KRun gets deleted before the dialog. i.e. insert ",this" as the 3rd arg. src/widgets/krun.cpp <https://git.reviewboard.kde.org/r/120666/#comment48412> It's a little bit surprising to see a getter ("is prompt needed") modify the KRun object. But OK, I can't think of a better solution right now. much better indeed, thanks - David Faure On Oct. 28, 2014, 7:50 a.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120666/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 7:50 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > This patch makes KIO show a dialog box asking the user what to do (either > open it using a text editor or execute it) when he clicks on a script or a > desktop file. > > See also: https://git.reviewboard.kde.org/r/120171/ > > > Diffs > ----- > > src/widgets/CMakeLists.txt 4060cdf > src/widgets/executablefileopendialog.cpp PRE-CREATION > src/widgets/executablefileopendialog_p.h PRE-CREATION > src/widgets/krun.cpp 6ac42da > src/widgets/krun_p.h 69e2e98 > > Diff: https://git.reviewboard.kde.org/r/120666/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
