> On Oct. 28, 2014, 10:05 a.m., David Faure wrote: > > src/widgets/krun.cpp, line 978 > > <https://git.reviewboard.kde.org/r/120666/diff/3/?file=322409#file322409line978> > > > > This should use the 4 args connect, in case the KRun gets deleted > > before the dialog. > > > > i.e. insert ",this" as the 3rd arg. > > Arjun AK wrote: > >i.e. insert ",this" as the 3rd arg > > Did you mean `q` ?
Yes, q will be fine. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review69246 ----------------------------------------------------------- On Oct. 28, 2014, 7:50 a.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120666/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 7:50 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > This patch makes KIO show a dialog box asking the user what to do (either > open it using a text editor or execute it) when he clicks on a script or a > desktop file. > > See also: https://git.reviewboard.kde.org/r/120171/ > > > Diffs > ----- > > src/widgets/CMakeLists.txt 4060cdf > src/widgets/executablefileopendialog.cpp PRE-CREATION > src/widgets/executablefileopendialog_p.h PRE-CREATION > src/widgets/krun.cpp 6ac42da > src/widgets/krun_p.h 69e2e98 > > Diff: https://git.reviewboard.kde.org/r/120666/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
