> On Feb. 25, 2014, 11:46 a.m., Alex Merry wrote: > > Generally looks good, but I'm wondering about the WIN32 clause. EGL is > > really just an API, right? What we're really searching for is the Mesa > > implementation. I guess that other platforms may well have their own > > implementations that, long term, it would be nice for this file to look > > for. In the meantime, it probably makes sense to print a message on WIN32 > > about how we're not looking for anything. Some of the stuff should then go > > outside the WIN32 clause, like find_package_handle_standard_args and > > set_package_properties. > > > > Also: what about APPLE? Does that use Mesa? > > > > Also: capitalisation. Shouldn't it be EGL, rather than Egl? > > Martin Gräßlin wrote: > egl should only be relevant to Unix systems. Traditionally we had: > * GLX for X11 > * CGL for Mac > * WGL for Windows > * EGL for Embedded > > That egl can also be used as a replacement for GLX is rather new (e.g. > latest NVIDIA driver) and I think that only holds for the unix systems so on > other platforms the respective native APIs should be used, but I honestly > don't know. Also we are not really searching for the Mesa implementation. We > are searching for any implementation, though on Linux that would normally be > the Mesa implementation which provides the pkg config file. I don't know how > that is when one installs the NVIDIA driver, though. AFAIK there are plans to > standardize this and have a generic provider for everything OpenGL related. > > Concerning capitalisation: I don't know, on Khronos it seems to be EGL, > so I'll change.
I don't really know much about EGL as such. I'm going off how the FindOpenGL.cmake file shipped with CMake works. At the very least, on WIN32, it should print a message and set EGL_FOUND to false. And the package properties should be set outside the if(WIN32) block. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/#review50800 ----------------------------------------------------------- On Feb. 25, 2014, 12:02 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116014/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 12:02 p.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, and > Alex Merry. > > > Repository: extra-cmake-modules > > > Description > ------- > > Add a FindEgl module > > This module finds the egl library through pkg-config. > > > Diffs > ----- > > find-modules/FindEgl.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/116014/diff/ > > > Testing > ------- > > Adjusted KWin to find egl through this cmake module. Picks up egl, compiles > and links. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
