----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/#review50800 -----------------------------------------------------------
Generally looks good, but I'm wondering about the WIN32 clause. EGL is really just an API, right? What we're really searching for is the Mesa implementation. I guess that other platforms may well have their own implementations that, long term, it would be nice for this file to look for. In the meantime, it probably makes sense to print a message on WIN32 about how we're not looking for anything. Some of the stuff should then go outside the WIN32 clause, like find_package_handle_standard_args and set_package_properties. Also: what about APPLE? Does that use Mesa? Also: capitalisation. Shouldn't it be EGL, rather than Egl? - Alex Merry On Feb. 25, 2014, 10:21 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116014/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 10:21 a.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, and > Alex Merry. > > > Repository: extra-cmake-modules > > > Description > ------- > > Add a FindEgl module > > This module finds the egl library through pkg-config. > > > Diffs > ----- > > find-modules/FindEgl.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/116014/diff/ > > > Testing > ------- > > Adjusted KWin to find egl through this cmake module. Picks up egl, compiles > and links. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
