> On Feb. 24, 2014, 2:51 p.m., Alex Merry wrote: > > Three things: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I've been aiming to create imported targets in new find modules, because > > they're easier to use (see FindSharedMimeInfo.cmake for an example, or the > > modules in kimageformats for better examples). > > Martin Gräßlin wrote: > Currently KWin and KInfoCenter are using egl. But also plasma-framework > is soon going to need it (that's the reason I opened the review ;-) ). > > Other points I will try to address (keep in mind that my cmake knowledge > might not be sufficient).
OK. I realised that e-c-m sorely needs some "writing a Find module" documentation. I'll get on that. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/#review50705 ----------------------------------------------------------- On Feb. 24, 2014, 1:08 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116014/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 1:08 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: extra-cmake-modules > > > Description > ------- > > Add a FindEgl module > > This module finds the egl library through pkg-config. > > > Diffs > ----- > > find-modules/FindEgl.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/116014/diff/ > > > Testing > ------- > > Adjusted KWin to find egl through this cmake module. Picks up egl, compiles > and links. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
