> On Sept. 17, 2013, 10:05 a.m., Chusslove Illich wrote: > > knewstuff/src/downloaddialog.cpp, line 35 > > <http://git.reviewboard.kde.org/r/112730/diff/1/?file=189543#file189543line35> > > > > Technically it is possible to mix translation frameworks, but I see no > > point > > to that. Certainly not because some piece of the build system gone > > stale. So > > yes, there should be a prepared way to apply uic with the options as in > > KDE > > 4. It is also logical for this now to be part of ki18n. Maybe located in > > ki18n/buildsys/cmake/, in case later some other build system gets > > support. > > > > David Faure wrote: > Agreed (except the path: the standard framework layout mandates > ki18n/cmake/). > > Jeremy, can you take care of it?
Thinking further, this operation is not exactly a straightforward copy of kde4uic.cmake with some name changing. I suggest getting this patch through as it is wrt. this issue, until I propose (soon :) and we review the new CMake support inside ki18n. Maybe just add trailing comment "TODO: support ki18n" to that qt5_wrap_ui call. - Chusslove ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review40194 ----------------------------------------------------------- On Sept. 17, 2013, 9:29 a.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112730/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2013, 9:29 a.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, David Faure, and > Chusslove Illich. > > > Description > ------- > > This makes it so I can mkdir build; cd build; cmake ../; make install from > knewstuff sources. > It's still using KDE4_KIO_LIBS and find_package(KIO) since not all of the kio > libraries have been split out apparently. > I'm not sure why sources had to be changed, but I had to add includes of > klocalizedstring where we didn't need them before somehow. > > > Diffs > ----- > > knewstuff/CMakeLists.txt 3fccbc6ee01a1cc8920321ee7125efb0bfc68412 > knewstuff/src/CMakeLists.txt c31398159459b79160ef76f193d6208d19953b4d > knewstuff/src/downloaddialog.cpp 3294c7c04c7879320fc0949db0310868bd6fa4fa > knewstuff/src/downloadwidget.cpp 64b7673d67b4e2f15007fc1a3f57d3da844d1dc0 > knewstuff/src/ui/entrydetailsdialog.cpp > 65b75d79941d9026f368f82c7b6df91d754e0925 > knewstuff/src/uploaddialog.cpp dbde573e8c3a477755c8c866d0ca1fccd1a35729 > > Diff: http://git.reviewboard.kde.org/r/112730/diff/ > > > Testing > ------- > > It builds and installs. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
