> On Sept. 17, 2013, 7:30 a.m., David Faure wrote: > > knewstuff/CMakeLists.txt, line 9 > > <http://git.reviewboard.kde.org/r/112730/diff/1/?file=189541#file189541line9> > > > > Does this really build when building all of kdelibs in one go? I > > thought we determined that find_package of kf5 components can't work as > > long as we build everything together? E.g. I see no > > find_package(KWindowSystem) in tier2/knotifications. > > > > If you want it to build both ways I think you have to add if (NOT > > kdelibs_SOURCE_DIR) around the find_package(K*). > > Jeremy Whiting wrote: > In looking at other libraries such as > http://git.reviewboard.kde.org/r/112811/ it seems if (NOT kdelibs_SOURCE_DIR) > isn't needed. why would find_package(KWindowSystem) need to be in > teir2/knotifications ?
We're both quite confused about this :) 112811 doesn't find_package(KSomeFramework) at all, does it? So I'm not sure how relevant it is, as an example for this change :) My point is that find_package(KSomeFramework) breaks when building kdelibs all-in-one from scratch. So either don't do it (and leave standalone builds of tier2/tier3 for later, as decided on the list), or at least put it inside a if (NOT kdelibs_SOURCE_DIR) to avoid breaking the all-in-one build. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review40193 ----------------------------------------------------------- On Sept. 17, 2013, 7:29 a.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112730/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2013, 7:29 a.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, David Faure, and > Chusslove Illich. > > > Description > ------- > > This makes it so I can mkdir build; cd build; cmake ../; make install from > knewstuff sources. > It's still using KDE4_KIO_LIBS and find_package(KIO) since not all of the kio > libraries have been split out apparently. > I'm not sure why sources had to be changed, but I had to add includes of > klocalizedstring where we didn't need them before somehow. > > > Diffs > ----- > > knewstuff/CMakeLists.txt 3fccbc6ee01a1cc8920321ee7125efb0bfc68412 > knewstuff/src/CMakeLists.txt c31398159459b79160ef76f193d6208d19953b4d > knewstuff/src/downloaddialog.cpp 3294c7c04c7879320fc0949db0310868bd6fa4fa > knewstuff/src/downloadwidget.cpp 64b7673d67b4e2f15007fc1a3f57d3da844d1dc0 > knewstuff/src/ui/entrydetailsdialog.cpp > 65b75d79941d9026f368f82c7b6df91d754e0925 > knewstuff/src/uploaddialog.cpp dbde573e8c3a477755c8c866d0ca1fccd1a35729 > > Diff: http://git.reviewboard.kde.org/r/112730/diff/ > > > Testing > ------- > > It builds and installs. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
